feat: Shim vim.ui.select to reuse as much of the code_action code #48
+53
−160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-progress PR because I noticed that a large part of this repo is a copy of
vim.lsp.buf.code_action
, which has changed since it was copied into thisrepository. To make it less possible for it to get out of date we can just call
vim.lsp.buf.code_action
directly and use a shim that interceptsvim.ui.select
to use theactions-preview
backend only ifkind == "codeaction"
.I chose to add the shim the first time
actions-preview
is called, otherwise(say if it was wrapped in
setup
) ifactions-preview
is loaded beforesomething else replaces
vim.ui.select
then we lose the shim. There may besome edge-cases around this wrapping that needs to be considered.
TODO: