Add errors to datadog traces #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Achieved by using the datadog-utils component which already does this. This will not be usable outside of Kroo, but the plan is to bring this in and make it private anyway as it's overly specific to our historical setup.
dominicfreeston
force-pushed
the
cloud-325-add-errors-to-datadog-traces
branch
from
dccefbd
to
dee0953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieved by deferring to the KSB variant of this library, which itself is using the datadog-utils component which already does this. This is done to avoid having to apply the same changes to two different versions of the same component.
Not for merging as it would turn a publicly available codebase into an internal one - here as validation that the tests still pass after the changes.