Skip to content

Commit

Permalink
Refactored code and unit tests to account for significantly updated d…
Browse files Browse the repository at this point in the history
…ependencies (#6)
  • Loading branch information
mangs authored Jul 21, 2023
1 parent e5c0869 commit c8b1fb8
Show file tree
Hide file tree
Showing 15 changed files with 1,075 additions and 4,567 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/publishWorkflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "16.17.0"
node-version: "18.16.1"
registry-url: https://npm.pkg.github.com
- id: super-cache
uses: mangs/super-cache-action@v3
Expand All @@ -26,4 +26,4 @@ jobs:
# NODE_AUTH_TOKEN: ${{ github.token }}
- uses: mangs/simple-release-notes-action@v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/pullRequestWorkflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "16.17.0"
node-version: "18.16.1"
registry-url: https://npm.pkg.github.com
- id: super-cache
uses: mangs/super-cache-action@v3
Expand Down
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# Changelog

## 2.0.1

- Refactored code and unit tests to account for significantly updated dependencies
- Vitest option `--coverage` removed from `test:unit` NPM script and moved into new NPM script `test:unit:coverage` because package `@vitest/coverage-v8` has a bug in it that causes messages to get logged to the console that should not be
- Added ESLint rule to require type imports to be in their own group
- Replaced Vitest coverage reporter `c8` with `v8` as necessitated by the migration to Vitest version `0.32.0`
- `validate:environment` NPM script now executes its subtasks in parallel
- Update GitHub Action workflow files to use Node.js version `18.16.1`
- Update expected internal NPM version to `9.5.1`
- Remove dev dependency `@vscode/ripgrep`, instead rely on locally-installed version because NPM package installs fail too often
- Update dependencies to latest

## 2.0.0

- Convert code to TypeScript
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# NPM module `@babbel/rollbar-client.js`

Tiny, modern Rollbar JavaScript client whose code is mostly lazy-loaded if and when an error occurs.
Tiny, modern Rollbar TypeScript client whose code is mostly lazy-loaded if and when an error occurs.

## Background and Overview

Expand Down
4 changes: 3 additions & 1 deletion config/eslint/eslintBaseConfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
{
"groups": [
["builtin", "external"],
["internal", "unknown", "parent", "sibling", "index", "object", "type"]
["internal", "unknown", "parent", "sibling", "index"],
["type"],
["object"]
],
"newlines-between": "always"
}
Expand Down
9 changes: 6 additions & 3 deletions config/eslint/eslintTypescriptConfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@
"extends": [
"./eslintBaseConfig.json",
"eslint-config-airbnb-typescript/base",
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:@typescript-eslint/recommended-type-checked",
"plugin:@typescript-eslint/stylistic-type-checked",
"eslint-config-prettier"
]
],
"rules": {
"@typescript-eslint/consistent-type-imports": "error"
}
}
2 changes: 1 addition & 1 deletion config/vite/vite.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default defineConfig({
test: {
clearMocks: true,
coverage: {
provider: 'c8',
provider: 'v8',
reportsDirectory: './vitestCodeCoverage',
},
environment: 'happy-dom',
Expand Down
Loading

0 comments on commit c8b1fb8

Please sign in to comment.