Skip to content

Commit

Permalink
Update process (#1)
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolo-ribaudo authored Apr 25, 2020
1 parent 4a459ec commit 62d7bf7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
12 changes: 7 additions & 5 deletions 0000-template.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
- Repo: (the repo it will be implemented in, e.g. [`babel/babel`](https://github.com/babel/babel))
- Start Date: (fill me in with today's date, YYYY-MM-DD)
- RFC PR: (leave this empty, to be filled in later)
- Related Issues: (if relevant)
- Authors: (the names of everyone contributing to this RFC)
- Repo: <!-- the repo it will be implemented in, e.g. `babel/babel` -->
- Start Date: <!-- fill me in with today's date, YYYY-MM-DD -->
- RFC PR: <!-- leave this empty, to be filled in later -->
- Related Issues: <!-- if relevant -->
- Authors: <!-- the names of everyone contributing to this RFC -->
- Champion: <!-- the name of a core team member that will present this RFC to the team. You can leave this empty if you haven't found it yet -->
- Implementors: <!-- the names of everyone who will work on the PR. you can leave this empty if you would like someone else to work on it -->

# Summary

Expand Down
12 changes: 8 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,23 @@ Some changes do not require an RFC:
In short, to get a major feature added, one usually first gets the RFC merged into the RFC repo as a markdown file. At that point the RFC is 'active' and may be implemented with the goal of eventual inclusion into Babel.

1. [Fork](https://github.com/babel/rfcs/fork) the RFC repo.
1. Copy `0000-template.md` to `text/0000-my-feature.md` (where 'my-feature' is descriptive. Don't assign an RFC number yet).
1. Copy `0000-template.md` to `rfcs/0000-my-feature.md` (where 'my-feature' is descriptive. Don't assign an RFC number yet).
1. Fill in the RFC. Put care into the details: RFCs that do not present convincing motivation, demonstrate understanding of the impact of the design, or are disingenuous about the drawbacks or alternatives tend to be poorly-received.
1. Submit a pull request. As a pull request the RFC will receive design feedback from the larger community, and the author should be prepared to revise it in response.
1. Build consensus and integrate feedback. RFCs that have broad support are much more likely to make progress than those that don't receive any comments.
1. Eventually, the team will decide whether the RFC is a candidate for inclusion.
1. RFCs that are candidates for inclusion will enter a "final comment period" lasting 3 calendar days. The beginning of this period will be signaled with a comment and tag on the RFCs pull request.
1. RFCs that are candidates for inclusion will enter a "final comment period" lasting one week. The beginning of this period will be signaled with a comment and tag on the RFCs pull request. Upon request of a Babel core team member, this period can be extended by an additional week.
1. An RFC can be modified based upon feedback from the team and community. Significant modifications may trigger a new final comment period.
1. An RFC may be rejected by the team after public discussion has settled and comments have been made summarizing the rationale for rejection. A member of the team should then close the RFCs associated pull request.
1. An RFC may be accepted at the close of its final comment period. A team member will merge the RFCs associated pull request, at which point the RFC will become 'active'.
1. If an RFC does not receive any comment for six months, it will be considered as 'stale' and closed. This does not mean that it is rejected, and the community can pick it up again.

## The RFC Lifecycle

Once an RFC is merged into this repo, then the authors may implement it and submit a pull request to the appropriate Babel repo without opening an issue. Note that the implementation still needs to be reviewed separate from the RFC, so you should expect more feedback and iteration.

Changes to the design during implementation should be reflected by updating the related RFC. The goal is to have RFCs to look back on to understand the motivation and design of shipped Babel features.
Changes to the design during implementation should be reflected by updating the related RFC with new PRs. The goal of having RFCs is to have something to look back upon to understand the motivation and design of shipped features/changes.
If the person writing the RFC is not the same person implementing it, we expect them to actively collaborate. If needed, this communication can be mediated by a team member.

## Implementing an RFC

Expand All @@ -58,6 +60,8 @@ If you are interested in working on the implementation for an 'active' RFC, but

## Reviewing RFCs

We try to make sure that any RFC that we accept is accepted at a team meeting. Every accepted feature should have a core team champion, who will represent the feature and its progress.
We try to make sure that any RFC that we accept is discussed at a team meeting. Every accepted feature should have a core team champion, who will represent the feature and its progress.

An RFC is considered as accepted if it receives at least 4 approving reviews, and no rejection from core team members. If the RFC is proposed by a core team member, this number is lowered to 3.

**Thanks to the [ESLint](https://github.com/eslint/rfcs) and [React](https://github.com/reactjs/rfcs) RFC process for inspiration.**

0 comments on commit 62d7bf7

Please sign in to comment.