This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 311
Filtertext #351
Open
m1tYo
wants to merge
2
commits into
babenkoivan:master
Choose a base branch
from
m1tYo:filtertext
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Filtertext #351
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,6 +151,44 @@ public function where($field, $value) | |
return $this; | ||
} | ||
|
||
/** | ||
* Exclude results containing text | ||
* Can't use 'term' because it's not analyzed | ||
* | ||
* @see https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-terms-query.html Terms query | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
* | ||
* @param string $field | ||
* @param array $value | ||
* @return $this | ||
*/ | ||
public function whereNotInText($field, $value) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it can be renamed to |
||
{ | ||
$this->wheres['must_not'][] = [ | ||
'match_phrase' => [ | ||
$field => $value | ||
] | ||
]; | ||
|
||
return $this; | ||
} | ||
|
||
/** | ||
* @see https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html Match query | ||
* | ||
* @param string $field | ||
* @param string $value | ||
* @return $this | ||
*/ | ||
public function whereMatch($field, $value) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you please remove this method? It was added and merged in PR #355 |
||
{ | ||
$this->wheres['must'][] = [ | ||
'match' => [ | ||
$field => $value, | ||
] | ||
]; | ||
return $this; | ||
} | ||
|
||
/** | ||
* Add a whereIn condition. | ||
* | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these comments since it's redundant