Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate events when nodes are approved/rejected #3772

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Generate events when nodes are approved/rejected #3772

wants to merge 9 commits into from

Commits on Apr 12, 2024

  1. Add node event emitter to concurrently run callback events

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0632042 View commit details
    Browse the repository at this point in the history

  2. Add deleted/connected/disconnected events

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9eddaf5 View commit details
    Browse the repository at this point in the history

  3. Hook up events to eval broker

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    13a3611 View commit details
    Browse the repository at this point in the history

  4. Switch to handler and mocks for testing

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4529b4b View commit details
    Browse the repository at this point in the history

  5. Handle connection/disconnection events

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    85cbacc View commit details
    Browse the repository at this point in the history

  6. Changes from PR review

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4ad5289 View commit details
    Browse the repository at this point in the history

  7. Actually use the mock Clock so we do not wait in test

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    256ef60 View commit details
    Browse the repository at this point in the history

  8. Add a timeout to the context to cleanup any remaining goroutines

    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    836ba77 View commit details
    Browse the repository at this point in the history

  9. Deliver events to manager-based component 

    We want to deliver events to a component that is able to use the job
store and the events delivered to interact with an evaluation broker.
This comment implements that event listener.
    @rossjones
    rossjones committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3b5ffbc View commit details
    Browse the repository at this point in the history