Slightly improve API error handling #4565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
reviewed
Sep 30, 2024
frrist
approved these changes
Sep 30, 2024
udsamani
approved these changes
Oct 1, 2024
jamlo
force-pushed
the
jamlo/api-error-handling
branch
from
0177a60
to
cf9789e
Compare
This commit tries to fix the "FromHttpResponse" function. Returning 2 errors from a function can be confusing and uncommon in Golang, especially if the function only returns these 2 errors. The new code code will return one error, which is always an APIError, and it also improves the error messaging wording, adding more details in the output. Several more tweaks can be done to the current error message handling if needed.
jamlo
force-pushed
the
jamlo/api-error-handling
branch
from
cf9789e
to
72e454e
Compare
|
What is the status of this PR? @jamlo feel free to merge if all comments are addressed |
|
@wdbaruni since this PR was created (through a fork) before I had access to the repo, I will close this one, and create another one from a branch to close the loop. |
|
Closing this PR in favor of #4607 |
jamlo
added a commit
that referenced
this pull request
Oct 8, 2024
This PR tries to fix the "FromHttpResponse" function. Returning 2 errors from a function can be confusing and uncommon in Golang, especially if the function only returns these 2 errors. The new code will return one error, which is always an APIError, and it also improves the error messaging wording, adding more details in the output. Several more tweaks can be done to the current error message handling if needed. Note: this is identical to [PR 4565](#4565), though created from a branch, and not a fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to fix the "FromHttpResponse" function. Returning 2 errors from a function can be confusing and uncommon in Golang, especially if the function only returns these 2 errors.
The new code will return one error, which is always an APIError, and it also improves the error messaging wording, adding more details in the output.
Several more tweaks can be done to the current error message handling if needed.