Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator enable streaming synthetic jobs #347

Merged
merged 11 commits into from
Jan 14, 2025
Merged

validator enable streaming synthetic jobs #347

merged 11 commits into from
Jan 14, 2025

Conversation

andreea-popescu-reef
Copy link
Contributor

No description provided.

@andreea-popescu-reef andreea-popescu-reef force-pushed the streamflow branch 6 times, most recently from 0f7acfb to cd6cc89 Compare December 19, 2024 08:43
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 2 times, most recently from fc20405 to 1cd803f Compare December 19, 2024 10:41
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 3 times, most recently from 2709c21 to 700925b Compare January 3, 2025 14:53
mpnowacki-reef
mpnowacki-reef requested changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@mpnowacki-reef mpnowacki-reef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no explicit tests of the streaming flow. Are there any?

validator/app/src/compute_horde_validator/validator/synthetic_jobs/batch_run.py Outdated Show resolved Hide resolved
validator/app/src/compute_horde_validator/validator/synthetic_jobs/batch_run.py Outdated Show resolved Hide resolved
@andreea-popescu-reef
Copy link
Contributor Author

andreea-popescu-reef commented Jan 6, 2025 •
edited
Loading

I see no explicit tests of the streaming flow. Are there any?

added some tests but the debug_run_mock_streaming_job_to_miner and debug_run_synthetic_job_to_miner commands are better test the streaming flow

@andreea-popescu-reef andreea-popescu-reef force-pushed the streamflow branch 3 times, most recently from e442d60 to 69a1390 Compare January 7, 2025 12:20
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 3 times, most recently from 6f5d618 to c05b293 Compare January 8, 2025 14:11
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 2 times, most recently from 78c386c to a21762b Compare January 9, 2025 15:45
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 3 times, most recently from 243cc46 to 7c6c126 Compare January 10, 2025 11:58
Base automatically changed from streamflow to master January 10, 2025 14:45
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 3 times, most recently from f67b186 to e00bb3a Compare January 13, 2025 13:58
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 3 times, most recently from 32a374e to 745ad6d Compare January 14, 2025 10:14
@andreea-popescu-reef andreea-popescu-reef force-pushed the streamsynth branch 3 times, most recently from f84705f to 0afe58e Compare January 14, 2025 13:32
@andreea-popescu-reef andreea-popescu-reef merged commit b252673 into master Jan 14, 2025
15 checks passed
@andreea-popescu-reef andreea-popescu-reef deleted the streamsynth branch January 14, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpnowacki-reef mpnowacki-reef mpnowacki-reef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreea-popescu-reef @mpnowacki-reef