-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miner: decline jobs when busy #365
base: master
Are you sure you want to change the base?
Conversation
aa4389a
to
9f3155e
Compare
9f3155e
to
bf73e8d
Compare
bf73e8d
to
b70ec6d
Compare
9820978
to
dc80180
Compare
7b3c050
to
6009c96
Compare
178367e
to
9ad5c0c
Compare
9ad5c0c
to
cac83f7
Compare
…mputeHorde into COM-178-job-rejection
validator/app/src/compute_horde_validator/validator/synthetic_jobs/batch_run.py
Show resolved
Hide resolved
validator/app/src/compute_horde_validator/validator/synthetic_jobs/batch_run.py
Outdated
Show resolved
Hide resolved
validator/app/src/compute_horde_validator/validator/synthetic_jobs/batch_run.py
Show resolved
Hide resolved
except ExecutorUnavailable: | ||
await self.group_discard(token) | ||
await job.adelete() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're deleting it? not saving how we excused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it's an "AcceptedJob" model. Does the miner need to remember excused jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validator also has a job model and that one is marked as excused, is that what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is not test checking that miner actually responds with V0DeclineJobRequest
with reason = BUSY
. I also can't spot a test chekcing the batch run properly setting valid excuses on jobs
611d436
to
07146e7
Compare
…orUnavailable instead to indicate no free executors
07146e7
to
f822d65
Compare
881f8c7
to
a4d8287
Compare
1c21a8c
to
9c1fcd6
Compare
9c1fcd6
to
a69f4ba
Compare
No description provided.