Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner: decline jobs when busy #365

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Conversation

kkowalski-reef
Copy link
Collaborator

No description provided.

@kkowalski-reef kkowalski-reef force-pushed the COM-178-job-rejection branch 2 times, most recently from 7b3c050 to 6009c96 Compare January 21, 2025 22:54
@kkowalski-reef kkowalski-reef force-pushed the COM-178-job-rejection branch 4 times, most recently from 178367e to 9ad5c0c Compare January 22, 2025 12:00
@emnoor-reef emnoor-reef changed the title (WIP) miner: decline jobs when busy miner: decline jobs when busy Jan 24, 2025
except ExecutorUnavailable:
await self.group_discard(token)
await job.adelete()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're deleting it? not saving how we excused?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's an "AcceptedJob" model. Does the miner need to remember excused jobs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator also has a job model and that one is marked as excused, is that what you mean?

Copy link
Contributor

@mpnowacki-reef mpnowacki-reef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is not test checking that miner actually responds with V0DeclineJobRequest with reason = BUSY. I also can't spot a test chekcing the batch run properly setting valid excuses on jobs

Copy link

github-actions bot commented Jan 28, 2025

Miner test report

35 tests  ±0   35 ✅ ±0   23s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 07146e7. ± Comparison against base commit 9037d4c.

♻️ This comment has been updated with latest results.

@kkowalski-reef kkowalski-reef force-pushed the COM-178-job-rejection branch 2 times, most recently from 611d436 to 07146e7 Compare January 28, 2025 17:56
…orUnavailable instead to indicate no free executors
Copy link

github-actions bot commented Jan 29, 2025

Validator test report

160 tests  ±0   158 ✅ ±0   41s ⏱️ ±0s
  1 suites ±0     2 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a69f4ba. ± Comparison against base commit c17e674.

♻️ This comment has been updated with latest results.

@kkowalski-reef kkowalski-reef force-pushed the COM-178-job-rejection branch 2 times, most recently from 1c21a8c to 9c1fcd6 Compare January 29, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants