-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] chore(deps): bump bitnami-common and bitnami-postgresql versions #232
base: main
Are you sure you want to change the base?
[WIP] chore(deps): bump bitnami-common and bitnami-postgresql versions #232
Conversation
5dfab2a
to
0e1b016
Compare
Thanks @coreydaley, beat me to it (although I was taking a while), for reference, this was the issue raised to bump the deps #191. Although I think we'll need a major version update to the Backstage Helm Chart as we are updating the Postgres Sub-Chart by 4 major versions. I'm wondering what we should do around testing? We don't want to cause problems for those who are on Postgres 12 (and haven't overridden the DB image chart values for it) |
@ChrisJBurns no worries, I would like to get the ability to set the |
0e1b016
to
2ac2e62
Compare
@ChrisJBurns The base helm install is working on minikube, can you authorize the workflow that is awaiting approval? |
@ChrisJBurns As far as the PostgreSQL getting upgraded, I think that documentation/release notes/education is the way to go, hopefully people will see that it is a major version bump and read the docs/notes. The upgrade from any major-to-major PostgreSQL version looks to be a manual process, probably using the pgupgrade command. We could also do some manual testing and see if a An alternative (maybe) would be to update this chart to bake in the version of PostgreSQL that is currently supported and people can upgrade if they want to? Would definitely have to be some manual verification of if that would work, but it seems like it would. If they have overridden it to a different version that should still work, and if not, the version would still be what they had before. |
@coreydaley Will approve the PR just to kick off the workflow, we can have a think in the meantime of the best way of going about the upgrade is and communicating that to users. |
Signed-off-by: Corey Daley <[email protected]>
2ac2e62
to
3104529
Compare
@ChrisJBurns Do you think this would be an appropriate topic for me to bring up on the SIG Framework call? |
@coreydaley Which SIG Framework are you referring to? Having a think, I'm wondering if we want to implement the incremental major bumps instead of jump from 12 to 16? This somewhat gives users the opportunity to minimise the amount of changes to the underlying chart per release? |
@ChrisJBurns Sorry, this one: https://github.com/backstage/community/tree/main/sigs/sig-framework Let me do a bit of testing and see what kind of issues we can expect and I'll post back my results here (hopefully early this week) |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Description of the change
The bitnami-common and bitnami-postgresql dependencies are pretty old and could use an update to provide expanded functionality for the Backstage Helm Chart. This update bumps both packages to their current latest versions
Existing or Associated Issue(s)
Fixes #191
Additional Information
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.