Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(announcements): add spacing to subheader of AnnouncementPage #2562

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(announcements): add spacing to subheader of AnnouncementPage #2562

wants to merge 4 commits into from

Conversation

benjidotsh
Copy link
Contributor

This PR adds spacing to the subheader of the AnnouncementPage component.

Before:
Scherm­afbeelding 2025-01-22 om 11 44 39

After:
Scherm­afbeelding 2025-01-22 om 11 43 05

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@benjidotsh benjidotsh requested a review from a team as a code owner January 22, 2025 10:45
@benjidotsh benjidotsh requested a review from BethGriggs January 22, 2025 10:45
kurtaking
kurtaking approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@kurtaking kurtaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

grantila pushed a commit to grantila/community-plugins that referenced this pull request Jan 24, 2025
@benjidotsh
plugin(announcements): add spacing to subheader of AnnouncementPage (b…
ef67a29 
…ackstage#2562)

* fix(announcements): add spacing to subheader of AnnouncementPage
* chore(announcements): improve changeset

Signed-off-by: Benjamin Janssens <[email protected]>
@kurtaking
Copy link
Member

@BethGriggs @benjidotsh - I updated the brach with main to prepare merging, and now the two files (changes) are gone 🫨

What happened 😨

@kurtaking kurtaking assigned kurtaking and benjidotsh and unassigned kurtaking Jan 28, 2025
@kurtaking kurtaking added the workspace/announcements Used to tag announcements workspace isses and pull requests label Jan 28, 2025
@kurtaking
Copy link
Member

Did force pushing this into another fork possibly merge this? It's part of the history on main.

image

@kurtaking kurtaking mentioned this pull request Jan 28, 2025
Merged
@benjidotsh
Copy link
Contributor Author

benjidotsh commented Jan 28, 2025 •
edited
Loading

@kurtaking hmm, it does look like this branch was (accidentally) pushed to main in ef67a29:
Scherm­afbeelding 2025-01-28 om 19 14 13

However, I don't understand why the commit is related to #2569:
Scherm­afbeelding 2025-01-28 om 19 21 53

@kurtaking
Copy link
Member

@kurtaking hmm, it does look like this branch was (accidentally) pushed to main in ef67a29: Scherm­afbeelding 2025-01-28 om 19 14 13

However, I don't understand why the commit is related to #2569: Scherm­afbeelding 2025-01-28 om 19 21 53

I don't either. @grantila do you have any insight here?

@grantila
Copy link
Contributor

No clue really, perhaps rebase on origin/main and see if that clears anything, or hard-reset to main and cherry pick the commits one by one to mitigate this.

gaelgoth pushed a commit to gaelgoth/community-plugins that referenced this pull request Jan 31, 2025
@benjidotsh @gaelgoth
plugin(announcements): add spacing to subheader of AnnouncementPage (b…
05134e8 
…ackstage#2562)

* fix(announcements): add spacing to subheader of AnnouncementPage
* chore(announcements): improve changeset

Signed-off-by: Benjamin Janssens <[email protected]>
Signed-off-by: gaelgoth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtaking kurtaking kurtaking approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees

@benjidotsh benjidotsh

Labels
workspace/announcements Used to tag announcements workspace isses and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjidotsh @kurtaking @grantila @BethGriggs