Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin(code-coverage): remove support for legacy backend #2587

Merged
merged 4 commits into from
Feb 4, 2025
Merged

plugin(code-coverage): remove support for legacy backend #2587

merged 4 commits into from
Feb 4, 2025

Conversation

04kash
Copy link
Member

@04kash 04kash commented Jan 27, 2025

Hey, I just made a Pull Request!

  • Removed usages and references of @backstage/backend-common
  • Removed support for legacy backend system

Related to: #1176

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@04kash 04kash requested review from alde and a team as code owners January 27, 2025 20:44
@04kash 04kash requested a review from BethGriggs January 27, 2025 20:44
@04kash 04kash force-pushed the code-coverage/remove-legacy-backend branch from a8efbba to 3b99e99 Compare January 27, 2025 20:44
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jan 27, 2025 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-code-coverage-backend workspaces/code-coverage/plugins/code-coverage-backend minor v0.5.0

awanlin
awanlin requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one too @04kash, just some README changes needed 👍

workspaces/code-coverage/plugins/code-coverage-backend/README.md Show resolved Hide resolved
04kash added 4 commits February 2, 2025 13:33
@04kash
plugin(code-coverage): remove support for legacy backend
f34ca3f 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash
yarn dedupe
e4c7729 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash
README fixes
b0662cb 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash
regen yarn
f3cfc3f 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash 04kash force-pushed the code-coverage/remove-legacy-backend branch from 5aad7da to f3cfc3f Compare February 2, 2025 18:40
awanlin
awanlin approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@awanlin awanlin merged commit 02cdb81 into backstage:main Feb 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alde alde alde approved these changes

@awanlin awanlin awanlin approved these changes

@BethGriggs BethGriggs Awaiting requested review from BethGriggs BethGriggs is a code owner automatically assigned from backstage/community-plugins-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@04kash @alde @awanlin