fix(rbac): reduce requests to credentials API #2955
+48
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr
requested review from
christoph-jerolimov,
PatAKnight and
a team
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Signed-off-by: Oleksandr Andriienko <[email protected]>
dzemanov
reviewed
Feb 25, 2025
|
|
||
| if (decision.result === AuthorizeResult.DENY) { | ||
| throw new NotAllowedError(); // 403 | ||
| if (credentials.principal.type !== 'user') { |
There was a problem hiding this comment.
Will the code get here (this)?
Maybe we can update the message there Only creadential principal with type 'user' permitted to modify permissions to:
Only credential principal of type 'user' is permitted to create or modify permissions
dzemanov
reviewed
Feb 25, 2025
|
|
||
| if (decision.result === AuthorizeResult.DENY) { | ||
| throw new NotAllowedError(); // 403 | ||
| if (credentials.principal.type !== 'user') { |
dzemanov
reviewed
Feb 25, 2025
|
|
||
| if (decision.result === AuthorizeResult.DENY) { | ||
| throw new NotAllowedError(); // 403 | ||
| if (credentials.principal.type !== 'user') { |
|
Tested and works fine. Only had some small comments. Thank you @AndrienkoAleksandr, this greatly cleans up the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Reduce requests to credentials API, simplify code a bit.
✔️ Checklist
Signed-off-byline in the message. (more info)