[manage] Fixed theming and the organization view #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
grantila
force-pushed
the
grantila/fix-manage-colors-and-org-view
branch
from
d4e8da9 to
d0a7de6
Compare
…groups Signed-off-by: Gustaf Räntilä <[email protected]>
grantila
force-pushed
the
grantila/fix-manage-colors-and-org-view
branch
from
d0a7de6 to
3ebe7b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined entities (page header) toggle
The top-right header label showing a "Combined" switch cannot easily be themed, as it didn't use the
<HeaderLabel>component which applies an overridable theme. This means that the text color can be unreadable for themes that have overridden the page header into something close to the regular background color.This PR uses a
<HeaderLabel>and also exports the combine switch component so it can be rendered separately (if the implementor wants other header labels as well), and also being able to choose the switch icon color.Organization view
The organization view showed not only all your parent groups (which is correct), but also each of their children groups, which basically shows the whole org. This was not the intention, and and although it's sometimes useful (for small and medium size organization) it can become cluttered for large organizations.
This PR defaults to only showing the group structure from the user and upwards by default. It adds two toggles to the view; To show the "whole organization" (i.e. follow group children), and to flip top-down to left-right.
The size of the view is also improved, so that the height of this graph adapts to the screen size. This reduces flickering and makes zooming in work better in that a graph that's very wide (and not very tall) can still be zoomed in to the whole screen estate available, and not only in the initial bounding box of the graph component.
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)