Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix badge style when logo only #10794

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Jan 9, 2025

Resolves #10628

It looks like there is no unit test for this. The badges below can used for previewing:

![](https://img.shields.io/badge/-blue?logo=amg)
![](https://img.shields.io/badge/-blue?logo=amg&style=social)
![](https://img.shields.io/badge/-blue?logo=amg&style=plastic)
![](https://img.shields.io/badge/-blue?logo=amg&style=flat-square)
![](https://img.shields.io/badge/-blue?logo=amg&style=for-the-badge)

![](https://img.shields.io/badge/-blue?logo=amg&logoSize=auto)
![](https://img.shields.io/badge/-blue?logo=amg&logoSize=auto&style=social)
![](https://img.shields.io/badge/-blue?logo=amg&logoSize=auto&style=plastic)
![](https://img.shields.io/badge/-blue?logo=amg&logoSize=auto&style=flat-square)
![](https://img.shields.io/badge/-blue?logo=amg&logoSize=auto&style=for-the-badge)









Copy link
Contributor

github-actions bot commented Jan 9, 2025

Messages
📖 ✨ Thanks for your contribution to Shields, @LitoMore!

Generated by 🚫 dangerJS against 1a70f04

@chris48s chris48s added the npm-package Badge generation and badge templates label Jan 10, 2025
Copy link
Contributor

🚀 Updated review app: https://pr-10794-badges-shields.fly.dev

@chris48s
Copy link
Member

Can we add snapshot test cases for this

@LitoMore
Copy link
Contributor Author

@chris48s Where should I add the snapshot test? The badge-maker/lib/make-badge.spec.mjs looks not in the test:package's scope. The test:package only runs .js files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm-package Badge generation and badge templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants