feat: generate images locally #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bafolts
force-pushed
the
bafolts/issue-40
branch
from
6000e76
to
a787905
Compare
| @@ -140,16 +140,8 @@ function getCompilerOptions(tsConfigFilePath?: string): ts.CompilerOptions { | |||
| } | |||
|
|
|||
| function requestImageFile(output: string, input: string, extension: string): void { | |||
There was a problem hiding this comment.
Added comment to share this part of code change with my team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes to running node-plantuml locally for generating images. I ran into dependency issues with the usage of tslint. Will migrate to eslint in separate PR. This closes #40 . Tested this locally generating a png file. Users will need to have graphviz installed locally. I had to update to most recent version with homebrew on mac.