Fuhrmanator/issue109 #121
Merged
Fuhrmanator/issue109 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repo is set to not use CRLF on clone
Unfortunately, functions are not representable in PlantUML. It's misleading to show them as methods, and there's a bug when a function is exported in a module that has no classes -- it shows in the PlantUML as a method without being inside a class (PlantUML crashes).
bafolts
reviewed
Feb 17, 2024
bafolts
reviewed
Feb 17, 2024
bafolts
reviewed
Feb 17, 2024
Co-authored-by: Brian Folts <[email protected]>
bafolts
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a fix for #109 -- I also updated the usage of Commander and glob.
Lastly, there is a bug fix where functions are being treated as methods (In the component factory). I made it as a separate commit. You may want to treat it separately?
This is a problem especially when a function doesn't belong to a class. The "method" line winds up in a PlantUML file, but it's outside of any class and causes PlantUML to fail.