Smarter cleaning rules for packages with SemVer #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated SDK in global.json - validated regression and unit tests
- added new in memory package database
robford123
reviewed
Sep 18, 2024
|
@robford123 Hey Rob, any chances you could look at integrating the PR? |
seriouz
reviewed
Nov 14, 2024
| /// If this is set to a value, it will limit the number of versions that can be pushed for a package. | ||
| /// the older versions will be deleted. | ||
| /// </summary> | ||
| public uint? MaxVersionsPerPackage { get; set; } = null; |
There was a problem hiding this comment.
What about people, who are currently using this setting? You must set it deprecated/obsolete.
If they are using it currently you should fill the new RetentionOptions with the value of MaxVersionsPerPackage. A message in the console should point them to the problem so they can move to the new configuration.
There was a problem hiding this comment.
Agree - I was hoping this PR would be rolled in release before my other one that had the MaxVersionsPerPackage
tests/BaGetter.Core.Tests/Services/PackageIndexingServiceInMemoryTests.cs
Show resolved
Hide resolved
tests/BaGetter.Core.Tests/Services/PackageIndexingServiceInMemoryTests.cs
Show resolved
Hide resolved
tests/BaGetter.Core.Tests/Services/PackageIndexingServiceInMemoryTests.cs
Show resolved
Hide resolved
Co-authored-by: seriouz <[email protected]> Signed-off-by: Erik <[email protected]>
Co-authored-by: seriouz <[email protected]> Signed-off-by: Erik <[email protected]>
Co-authored-by: seriouz <[email protected]> Signed-off-by: Erik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smarter cleaning rules for packages
betaandalphathis will keepMaxHistoryPerPrereleaseversions for bothbetaandalpha.