issue=#907 bugfix of replication sdk

baidu · Jun 7, 2016 · 856303f · 856303f
1 parent fdc6cc1
commit 856303f
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/sdk/tera_replication.cc b/src/sdk/tera_replication.cc
@@ -188,10 +188,6 @@ class RowReaderReplicateImpl : public RowReaderReplicate {
 
     virtual void SetCallBack(Callback callback) {
         _user_callback = callback;
-        for (size_t i = 0; i < _row_readers.size(); i++) {
-            _row_readers[i]->SetCallBack(RowReaderCallback);
-            _row_readers[i]->SetContext(this);
-        }
     }
 
     virtual void SetContext(void* context) {
@@ -298,7 +294,11 @@ class TableReplicateImpl : public TableReplicate {
         bool is_async = mutation_rep_impl->IsAsync();
         const std::vector<RowMutation*>& mutation_list = mutation_rep_impl->GetRowMutationList();
         const std::vector<Table*>& table_list = mutation_rep_impl->GetTableList();
-        for (size_t i = 0; i < mutation_list.size(); i++) {
+        // in async mode, after the last call of ApplyMutation, we should not access
+        // 'mutation_rep_impl' anymore, that's why we assign the value of 'mutation_list.size()'
+        // to a local variable 'mutation_num'
+        size_t mutation_num = mutation_list.size();
+        for (size_t i = 0; i < mutation_num; i++) {
             table_list[i]->ApplyMutation(mutation_list[i]);
         }
         if (!is_async) {
@@ -327,7 +327,8 @@ class TableReplicateImpl : public TableReplicate {
         bool is_async = reader_rep_impl->IsAsync();
         const std::vector<RowReader*>& reader_list = reader_rep_impl->GetRowReaderList();
         const std::vector<Table*>& table_list = reader_rep_impl->GetTableList();
-        for (size_t i = 0; i < reader_list.size(); i++) {
+        size_t reader_num = reader_list.size();
+        for (size_t i = 0; i < reader_num; i++) {
             table_list[i]->Get(reader_list[i]);
         }
         if (!is_async) {