Swap query support for hooks that require account #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPereira
commented
Sep 6, 2024
MattPereira
commented
Sep 6, 2024
johngrantuk
reviewed
Sep 9, 2024
johngrantuk
reviewed
Sep 11, 2024
| { blockNumber: block }, | ||
| ); | ||
| const { result } = account | ||
| ? // pseudo query fails if account has insufficient allowance or balance |
There was a problem hiding this comment.
Don't have a big preference on ternary vs another method but did find it pretty tricky to notice the ? with the comment inline like this.
There was a problem hiding this comment.
ya that is pretty bad 😬
I couldn't quite remember what you wanted me to do with the caveat. Should it be a comment in code or is it just something to keep in mind moving forward?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398
Status: On Hold
Summary
accounttoquerySingleSwapandqueryBatchSwap( for v3 only )pnpm example ./examples/swaps/customSwap.tsaccountis my dev wallet which holds the mock veBAL the hooks contract checks for