Kassandra Managed pool #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pools/index.ts
Outdated
Comment on lines
96
to
97
| else if (pool.poolType === 'Managed') | ||
| newPool = KassandraManagedPool.fromPool(pool); |
There was a problem hiding this comment.
This is the only part that I don't have a clear answer at the moment.
In case anyone else creates a new Managed Pool with different config from yours, the SOR might break.
Are you guys planning on releasing any subsequent Managed Pool?
If yes, is there anything in common with the current one that we can use as a second identifier? Maybe the owner address?
If not, we could even use the poolId as an intermediate solution until we need to develop a more generalized approach.
guilherme-correa-s
changed the base branch from
develop
to
managed-kassandra
brunoguerios
merged commit 1888e7a
into
balancer:managed-kassandra
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add Kassandra Managed Pool for swap token to token.
For math we use WeightedMath.
If you need further testing or any changes, just comment. thanks.