Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BBE for Regex replace operations #5679

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add BBE for Regex replace operations #5679

wants to merge 4 commits into from

Conversation

poorna2152
Copy link
Contributor

MaryamZi
MaryamZi reviewed Oct 16, 2024
View reviewed changes
examples/index.json
@@ -1201,6 +1201,13 @@
"verifyBuild": true,
"verifyOutput": true,
"isLearnByExample": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the BBE before this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm1990 do we need to do anything for redirects with this change in BBE name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poorna2152 note that the regexp type BBE has a link to this too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaryamZi yes. I'll have to update the Google search index.
@poorna2152 Please share the old BBE url and the new BBE url.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old link: https://ballerina.io/learn/by-example/regexp-operations/
New link: https://ballerina.io/learn/by-example/regexp_operations_overview/

@poorna2152 poorna2152 force-pushed the regex_replace branch 3 times, most recently from 473b595 to bac1a43 Compare October 21, 2024 05:59
SasinduDilshara
SasinduDilshara reviewed Oct 21, 2024
View reviewed changes
examples/regexp-replace-operations/regexp_replace_operations.out Outdated
@@ -0,0 +1,3 @@
$ bal run regexp_replace_operations.bal
****-****-****-5432
XML string with comments removed: <root><e1>value1</e1><e2>value2</e2>&gt;</root>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
XML string with comments removed: <root><e1>value1</e1><e2>value2</e2>&gt;</root>
XML string with comments removed: <root><e1>value1</e1><e2>value2</e2>&gt;</root>

MaryamZi
MaryamZi reviewed Oct 21, 2024
View reviewed changes
examples/index.json
@@ -1201,6 +1201,13 @@
"verifyBuild": true,
"verifyOutput": true,
"isLearnByExample": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm1990 do we need to do anything for redirects with this change in BBE name?

examples/regexp-operations/regexp_operations_overview.bal Outdated Show resolved Hide resolved
@sm1990
Copy link
Contributor

sm1990 commented Oct 24, 2024

@MaryamZi are there any learn or other BBE pages that refers to this particular BBE?

@MaryamZi
Copy link
Member

@MaryamZi are there any learn or other BBE pages that refers to this particular BBE?

Yes, the regexp type BBE - #5679 (comment)

cc @poorna2152

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MaryamZi
MaryamZi reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM. Need to sort out anything related to redirection due to BBE name/folder changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm1990 sm1990 sm1990 left review comments

@MaryamZi MaryamZi MaryamZi left review comments

@SasinduDilshara SasinduDilshara SasinduDilshara left review comments

@NipunaRanasinghe NipunaRanasinghe Awaiting requested review from NipunaRanasinghe NipunaRanasinghe is a code owner

@gimantha gimantha Awaiting requested review from gimantha gimantha is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poorna2152 @sm1990 @MaryamZi @SasinduDilshara