Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time zone BBE #5684

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Add time zone BBE #5684

merged 2 commits into from
Sep 30, 2024

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Sep 27, 2024 •
edited
Loading

Purpose

Subject

Fixes: ballerina-platform/ballerina-dev-website#9362

Note: Even though we expose a time:loadSystemZone() API to get the system time zone, I have used the time:TimeZone() in this BBE. This is due a compiler error we are getting when we have ballerina cache. Once that is fixed we can update this BBE as well.

daneshk
daneshk previously approved these changes Sep 27, 2024
View reviewed changes
NipunaRanasinghe
NipunaRanasinghe reviewed Sep 27, 2024
View reviewed changes
examples/time-zone/time_zone.bal Outdated Show resolved Hide resolved
examples/time-zone/time_zone.bal Outdated Show resolved Hide resolved
examples/time-zone/time_zone.bal Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

NipunaRanasinghe
NipunaRanasinghe approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TharmiganK TharmiganK added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit e0f83cd Sep 30, 2024
5 checks passed
@TharmiganK TharmiganK deleted the time-zone-bbe branch September 30, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe approved these changes

@MaryamZi MaryamZi Awaiting requested review from MaryamZi MaryamZi is a code owner

@gimantha gimantha Awaiting requested review from gimantha gimantha is a code owner

@sm1990 sm1990 Awaiting requested review from sm1990

@daneshk daneshk Awaiting requested review from daneshk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a BBE for time zone API usage
3 participants
@TharmiganK @daneshk @NipunaRanasinghe