Merge pull request #42738 from chiranSachintha/fix-42728

Fix file too large error due to unnecessary node cloning
ballerina-platform · May 22, 2024 · c09a92c · c09a92c
2 parents 0b650e5 + f68436c
commit c09a92c
Show file tree

Hide file tree

Showing 5 changed files with 439 additions and 9 deletions.
diff --git a/...na-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java b/...na-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
@@ -1893,18 +1893,12 @@ private BType checkListConstructorCompatibility(BType referredType, BType origin
                 return new BTypedescType(listConstructor.typedescType, null);
         }
 
-        BLangListConstructorExpr exprToLog = listConstructor;
-        if (data.commonAnalyzerData.nonErrorLoggingCheck) {
-            listConstructor.cloneAttempt++;
-            exprToLog = nodeCloner.cloneNode(listConstructor);
-        }
-
         if (referredType == symTable.semanticError) {
             // Ignore the return value, we only need to visit the expressions.
-            getInferredTupleType(exprToLog, symTable.semanticError, data);
-        } else {
+            getInferredTupleType(listConstructor, symTable.semanticError, data);
+        } else if (!data.commonAnalyzerData.nonErrorLoggingCheck) {
             dlog.error(listConstructor.pos, DiagnosticErrorCode.INCOMPATIBLE_TYPES, originalType,
-                    getInferredTupleType(exprToLog, symTable.noType, data));
+                       getInferredTupleType(listConstructor, symTable.noType, data));
         }
 
         return symTable.semanticError;

diff --git a/tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/jvm/CodegenErrorsTest.java b/tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/jvm/CodegenErrorsTest.java
@@ -103,6 +103,10 @@ public void testLargeMethods3() {
         BRunUtil.runMain(testLargeMethods3Result);
     }
 
+    public void testLargeMethods4() {
+        BCompileUtil.compile("test-src/jvm/largeMethods4");
+    }
+
     @Test
     public void testLargeNumberOfListeners() {
         CompileResult compileResult = BCompileUtil.compile("test-src/jvm/large-number-of-listeners.bal");

diff --git a/tests/jballerina-unit-test/src/test/resources/test-src/jvm/largeMethods4/.gitignore b/tests/jballerina-unit-test/src/test/resources/test-src/jvm/largeMethods4/.gitignore
@@ -0,0 +1,2 @@
+target
+Dependencies.toml
diff --git a/tests/jballerina-unit-test/src/test/resources/test-src/jvm/largeMethods4/Ballerina.toml b/tests/jballerina-unit-test/src/test/resources/test-src/jvm/largeMethods4/Ballerina.toml
@@ -0,0 +1,7 @@
+[build-options]
+observabilityIncluded = false
+
+[package]
+org = "testOrg"
+name = "largeMethods4"
+version = "0.1.0"