Address review suggestions

ballerina-platform · Oct 7, 2024 · e9e726b · e9e726b
1 parent 08e776c
commit e9e726b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/...ebug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JBallerinaDebugServer.java b/...ebug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JBallerinaDebugServer.java
@@ -1107,8 +1107,7 @@ private void attachToRemoteVM(String hostName, int portName) throws IOException,
         VirtualMachine attachedVm = executionManager.attach(hostName, portName);
         context.setDebuggeeVM(new VirtualMachineProxyImpl(attachedVm));
         EventRequestManager erm = context.getEventManager();
-        ClassPrepareRequest classPrepareRequest = erm.createClassPrepareRequest();
-        classPrepareRequest.enable();
+        erm.createClassPrepareRequest().enable();
         erm.createThreadStartRequest().enable();
         erm.createThreadDeathRequest().enable();
         eventProcessor.startListening();

diff --git a/...es/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JDIEventProcessor.java b/...es/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JDIEventProcessor.java
@@ -45,6 +45,7 @@
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 import static org.ballerinalang.debugadapter.BreakpointProcessor.DynamicBreakpointMode;
 import static org.ballerinalang.debugadapter.JBallerinaDebugServer.isBalStackFrame;
@@ -59,8 +60,8 @@ public class JDIEventProcessor {
     private final BreakpointProcessor breakpointProcessor;
     private boolean isRemoteVmAttached = false;
     private final List<EventRequest> stepRequests = new ArrayList<>();
+    private static final List<ThreadReference> virtualThreads = new CopyOnWriteArrayList<>();
     private static final Logger LOGGER = LoggerFactory.getLogger(JDIEventProcessor.class);
-    private static final List<ThreadReference> virtualThreads = new ArrayList<>();
 
     JDIEventProcessor(ExecutionContext context) {
         this.context = context;
@@ -132,16 +133,13 @@ private void processEvent(EventSet eventSet, Event event) {
         } else if (event instanceof ThreadStartEvent threadStartEvent) {
             ThreadReference thread = threadStartEvent.thread();
             if (thread.isVirtual()) {
-                synchronized (virtualThreads) {
-                    virtualThreads.add(thread);
-                }
+                virtualThreads.add(thread);
+
             }
             eventSet.resume();
         } else if (event instanceof ThreadDeathEvent threadDeathEvent) {
             ThreadReference thread = threadDeathEvent.thread();
-            synchronized (virtualThreads) {
-                virtualThreads.remove(thread);
-            }
+            virtualThreads.remove(thread);
             eventSet.resume();
         } else {
             eventSet.resume();