Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML member access type and allow XML langlib calls with unions #43421

Merged

Conversation

MaryamZi
Copy link
Member

Purpose

$title.

Fixes #35019
Fixes #28697

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@MaryamZi MaryamZi added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (b45e1e1) to head (2f37ab3).
Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43421      +/-   ##
============================================
- Coverage     77.51%   77.50%   -0.01%     
- Complexity    58585    58591       +6     
============================================
  Files          3438     3438              
  Lines        219219   219230      +11     
  Branches      28921    28917       -4     
============================================
- Hits         169921   169909      -12     
- Misses        39884    39908      +24     
+ Partials       9414     9413       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaryamZi MaryamZi requested a review from gimantha October 8, 2024 05:56
@gimantha gimantha merged commit b67b420 into ballerina-platform:master Oct 8, 2024
16 checks passed
@MaryamZi MaryamZi deleted the fix-xml-member-access-type branch October 8, 2024 09:23
@MaryamZi MaryamZi added this to the 2201.11.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
2 participants