Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java 21] Remove Gson usage from Testerina Runtime #43425

Draft
wants to merge 2 commits into
base: java21
Choose a base branch
from

Conversation

ravinperera00
Copy link
Contributor

Purpose

This allows for the removal of com.google.gson dependency from Ballerina-rt.

Fixes #43416

Approach

Implement the lost functionality using internal alternatives.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Comment on lines +115 to +116
Object jsonObj = JsonUtils.parse(br, JsonUtils.NonStringValueProcessingMode.FROM_JSON_STRING);
BMap<BString, Object> testSuiteMap = (BMap<BString, Object>) jsonObj;
Copy link
Contributor

@HindujaB HindujaB Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Object jsonObj = JsonUtils.parse(br, JsonUtils.NonStringValueProcessingMode.FROM_JSON_STRING);
BMap<BString, Object> testSuiteMap = (BMap<BString, Object>) jsonObj;
BMap<BString, Object> testSuiteMap = (BMap<BString, Object>) JsonUtils.parse(br,
JsonUtils.NonStringValueProcessingMode.FROM_JSON_STRING);

Because we only use jsonObj in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants