-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java 21] Remove H:Name
and H:Path
GraalVM experimental options from runtime
#43493
base: java21
Are you sure you want to change the base?
[Java 21] Remove H:Name
and H:Path
GraalVM experimental options from runtime
#43493
Conversation
@@ -86,4 +86,4 @@ EXAMPLES | |||
$ bal build <app-package-path> | |||
|
|||
Build the package with additional GraalVM native image options. | |||
$ bal build --graalvm --graalvm-build-options="--static -H:Name=hello-world" | |||
$ bal build --graalvm --graalvm-build-options="--static -o <entire-file-path-with-name>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use the -o
option again
Since this is an example for the --graalvm-build-options
we may add this --enable-monitoring
option instead of -H:Name=hello-world
option
$ bal build --graalvm --graalvm-build-options="--static -o <entire-file-path-with-name>" | |
$ bal build --graalvm --graalvm-build-options="--static --enable-monitoring" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'll fix these.
@@ -187,4 +187,4 @@ EXAMPLES | |||
$ bal test -Cval1=add -Cval2=10 -Cval3=5 | |||
|
|||
Test the package with additional GraalVM native image options. | |||
$ bal test --graalvm --graalvm-build-options="--static -H:Name=hello-world" | |||
$ bal test --graalvm --graalvm-build-options="--static -o <entire-file-path-with-name>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the previous comment
@@ -86,7 +86,7 @@ public void testBuildProjectWithAdditionalArgs() throws IOException { | |||
Path projectPath = this.testResources.resolve("nativeimageProject"); | |||
System.setProperty(ProjectConstants.USER_DIR, projectPath.toString()); | |||
BuildCommand buildCommand = new BuildCommand(projectPath, printStream, printStream, false, | |||
false, true, "-H:Name=hoo"); | |||
false, true, "-o " + projectPath + "/hoo"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this overwrite the output path? Is the test passing with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. The tests actually do pass. I'll have a deeper look.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## java21 #43493 +/- ##
============================================
+ Coverage 75.01% 77.24% +2.22%
- Complexity 56725 58256 +1531
============================================
Files 3447 3447
Lines 218878 218847 -31
Branches 28846 28852 +6
============================================
+ Hits 164187 169044 +4857
+ Misses 45736 40422 -5314
- Partials 8955 9381 +426 ☔ View full report in Codecov by Sentry. |
Purpose
Fixes part of ballerina-platform/ballerina-library#7252
Approach
Check List