Add DependencyManifest module to the PackageManifest dependency #43524
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When a package is found both in PackageManifest(Ballerina.toml) and the DependencyManifest(Dependencies.toml) we pick the dependency in the PackageManifest. This will go in the BlendedManifest. However, with that, we loose the information regarding the modules that are within the package since the user only specifies the
org
,name
,version
andrepository
(optional).When this happens to a package that has a hierarchical name (eg - resource.kind), we cannot find a module that matches the the aforementioned dependency in the BlendedManifest because when trying to compare the module names, the entry in the BlendedManifest has an empty module list.
With this fix, when the same dependency is repeated in both Dependencies.toml and the Ballerina.toml, the module details are copied from the Dependencies.toml while other details are taken from the Ballerina.toml
Fixes https://github.com/wso2-enterprise/internal-support-ballerina/issues/811
Approach
Samples
Remarks
Check List