Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid caching narrow type #43857

Merged

Conversation

heshanpadmasiri
Copy link
Member

Purpose

Avoid unnecessary caching narrow types

Fixes #43853

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@heshanpadmasiri heshanpadmasiri force-pushed the fix/memory-leak branch 2 times, most recently from cca787b to ddcb917 Compare February 28, 2025 07:41
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.29%. Comparing base (000d1dc) to head (a61513f).
Report is 15 commits behind head on 2201.12.x.

Files with missing lines Patch % Lines
...llerina/runtime/internal/types/TypeIdSupplier.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             2201.12.x   #43857   +/-   ##
============================================
  Coverage        77.29%   77.29%           
- Complexity       59052    59079   +27     
============================================
  Files             3538     3539    +1     
  Lines           222256   222303   +47     
  Branches         28820    28827    +7     
============================================
+ Hits            171797   171839   +42     
+ Misses           40759    40758    -1     
- Partials          9700     9706    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimantha gimantha marked this pull request as ready for review February 28, 2025 14:11
@gimantha gimantha merged commit 8d411a0 into ballerina-platform:2201.12.x Feb 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants