Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Listener Throwing Error when Passing Configurables as Listener Configurations #2147

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ThisaruGuruge
Copy link
Member

Purpose

Fixes: #7502

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • No commons package changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)
  • No compiler package changes (if there are any, please update the GraphQL version in Ballerina dev tools)

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 78.02198% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (04cfa43) to head (8fbcfac).

Files with missing lines Patch % Lines
ballerina/listener.bal 79.06% 18 Missing ⚠️
ballerina/listener_utils.bal 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2147      +/-   ##
============================================
+ Coverage     80.52%   82.94%   +2.41%     
- Complexity        0      818     +818     
============================================
  Files            93      127      +34     
  Lines          6918     9849    +2931     
  Branches       1537     2054     +517     
============================================
+ Hits           5571     8169    +2598     
- Misses         1263     1335      +72     
- Partials         84      345     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThisaruGuruge ThisaruGuruge force-pushed the listener-config-fix branch 2 times, most recently from 8fc171a to e723107 Compare January 29, 2025 08:36
Copy link
Member

@ayeshLK ayeshLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisaruGuruge ThisaruGuruge merged commit 999a585 into master Jan 29, 2025
6 checks passed
@ThisaruGuruge ThisaruGuruge deleted the listener-config-fix branch January 29, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot make the graphql:ListenerConfiguration as a configurable variable
3 participants