-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CaseOverview): UBO risk indicator title #3042
base: dev
Are you sure you want to change the base?
Conversation
- Replace inline tab logic with a dedicated function - Ensure 'ubos' case returns the correct tab name - Maintain existing functionality for other domain tab names
|
WalkthroughThis update refines tab name generation in the CaseOverview component and adjusts the git diff command in the auto-commit script. A new helper function Changes
Sequence Diagram(s)sequenceDiagram
participant Component as CaseOverview Component
participant getTab as getTab()
participant camelCase as camelCase()
Component->>getTab: Call with domain value
alt Domain is "ubos"
getTab-->>Component: Return "ubos"
else
getTab->>camelCase: Convert domain to camelCase
camelCase-->>getTab: Return converted string
getTab-->>Component: Return camelCase string
end
sequenceDiagram
participant Script as auto-commit Script
participant Git as Git Diff Command
Script->>Git: Execute `git diff --cached -- . ":(exclude)pnpm-lock.yaml"`
Git-->>Script: Return diff excluding pnpm-lock.yaml changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The notion rules had 'Domain' as 'UBOs'
This does not match the mapping in
TabToLabel
because ofso it would default back to use:
Summary by CodeRabbit
New Features
Chores