Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Do not merge** dev -> sb #3050

Merged
merged 19 commits into from
Feb 14, 2025
Merged

**Do not merge** dev -> sb #3050

merged 19 commits into from
Feb 14, 2025

Conversation

Omri-Levy
Copy link
Contributor

No description provided.

codechirag123 and others added 7 commits February 10, 2025 15:38
@codechirag123
Dev 336/amplify webhook builds (#2906)
130b240 
* feat: added new actions to build front-end apps manually

* fix: fixed a typo

* fix: changed the action names for the new front-end build actions

* feat: added on-failuew job to notify when the job fails

* fix: added changes code rabbit

* fix: removed redundant step for build action

* chore: removing on push trigger on the actions
@liorzam
[bal-3442] - Backoffice - Display timestamp in local timezone for tra…
214490c 
…nsaction monitoring (#3037)
@alonp99
fix(transaction.mapper): remove unnecessary success log on validation (…
2c5db8a 
…#3023)

- Eliminate console.log for successful validation
- Clean up the code for improved readability

(your logs are so verbose, they could be mistaken for a motivational speech)
@alonp99
feat(docs): add development rules for backoffice-v2, kyb-app, workflo…
ac76b0c 
…ws-dashboard (#3038)

* feat(docs): add development rules for backoffice-v2, kyb-app, workflows-dashboard

- Introduce best practices for React TypeScript development
- Include guidance on components, hooks, state management, and testing

(These rules are so thorough, they could double as a user manual for a space shuttle)

* docs(workflows): enhance workflow service rules and guidelines

- Expand code organization and structure guidelines
- Introduce TypeScript usage best practices
- Include detailed documentation on error handling and API design

(Your code organization is so messy, it makes a cluttered desk look like a minimalist art piece)
@pratapalakshmi @codechirag123 @alonp99
chore: run dist with environment variables (#2643) (#3041)
351d0bb 
* chore: run dist with environment variables (#2643)

* fix: adding trimmer in end of env name

---------

Co-authored-by: ChiragSharma <[email protected]>
Co-authored-by: Alon Peretz <[email protected]>
@shanegrouber @alonp99
refactor(EditableDetails): optimize form handling with useMemo (#3048)
d0029e7 
- Replace direct defaultValues assignment with memoized formValues
- Remove unnecessary useEffect for form reset on data change
- Simplify conditional rendering logic in the return statement

Co-authored-by: Alon Peretz <[email protected]>
@tomer-shvadron
refactor(components): streamline details component properties access (#…
36b1b8c 
…3049)

- Remove optional chaining for value.id and value.title
- Improve readability by ensuring direct property access

refactor(hooks): add workflowId to bankAccount and credit check blocks

- Update hooks to receive workflowId for better context handling
- Simplify conditional checks for plugin outputs

chore(migrations): update subproject commit reference

- Sync submodule to latest commit in workflows-service
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 686df12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MatanYadaev
Use report_outcomes for report display (#3035)
fc5dbfd 
* fix: table page

* wip

* fix: formating

* wip

* fix: small fixes

* fix

* fix: ui bug

* build: new version

* fix: validate report metadata

* fix: pr comments
@ArtemLavrentii
feat(bal-3616): added demo account config option (#3046)
49b3ae3 
* feat(bal-3616): added demo account config option

* chore: pr review fixes
@chesterkmr
Illiar/feat/common document schemas (#3051)
2f8b19d 
* feat: added pci-certification document

* feat: added financial document && bump

* fix: lock fix
@Omri-Levy Omri-Levy changed the title dev -> sb **Do not merge** dev -> sb Feb 14, 2025
@chesterkmr chesterkmr merged commit 5d1bcb2 into sb Feb 14, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonp99 alonp99 alonp99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Omri-Levy @alonp99 @MatanYadaev @chesterkmr @ArtemLavrentii @codechirag123 @liorzam @pratapalakshmi @shanegrouber @tomer-shvadron