chore: fix line calc

baloise · Jan 12, 2025 · f943b91 · f943b91
1 parent 65de5b7
commit f943b91
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/e2e/cypress/e2e/visual/bal-carousel.visual.cy.ts b/e2e/cypress/e2e/visual/bal-carousel.visual.cy.ts
@@ -29,7 +29,7 @@ describe('bal-carousel', () => {
     })
   })
 
-  describe.only('product-slider', () => {
+  describe('product-slider', () => {
     it('combi with tabs', () => {
       cy.visit('/components/bal-carousel/test/bal-carousel-tabs.visual.html').platform('desktop').waitForDesignSystem()
       cy.get('.bal-tabs__nav__item').last().click()

diff --git a/packages/core/src/components/bal-tabs/bal-tabs.tsx b/packages/core/src/components/bal-tabs/bal-tabs.tsx
@@ -308,7 +308,7 @@ export class Tabs
   @ListenToResize()
   resizeListener(info: BalResizeInfo) {
     this.swiper.notifyChange()
-    if ((!this.isVertical && info.width) || (this.isVertical && info.height)) {
+    if ((!this.isVertical() && info.width) || (this.isVertical() && info.height)) {
       this.animateLine()
     }
   }
@@ -449,7 +449,6 @@ export class Tabs
   }
 
   private getCarouselElement(): HTMLElement | null {
-    // return this.el.querySelector(`#${this.tabsId}-carousel`)
     return this.el.querySelector(`#${this.swiper.containerId}`)
   }
 

diff --git a/packages/core/src/utils/resize/resize.listener.ts b/packages/core/src/utils/resize/resize.listener.ts
@@ -1,11 +1,11 @@
 import { balBrowser } from '../browser'
-import { debounce, rIC } from '../helpers'
+import { debounce } from '../helpers'
 import { ListenerAbstract } from '../types/listener'
 import { BalResizeInfo } from './resize.interfaces'
 
 export class BalResizeListener<TObserver> extends ListenerAbstract<TObserver, BalResizeInfo> {
   private resizeObserver: ResizeObserver | undefined
-  private debouncedNotify = debounce((info: BalResizeInfo) => this.notify(info), 10)
+  private debouncedNotify = debounce((info: BalResizeInfo) => this.notify(info), 42)
   private lastWidth: number | undefined
   private lastHeight: number | undefined
 
@@ -36,12 +36,10 @@ export class BalResizeListener<TObserver> extends ListenerAbstract<TObserver, Ba
             const heightChanged = this.lastHeight !== entry.contentRect.height
 
             if (widthChanged || heightChanged) {
-              rIC(() =>
-                this.debouncedNotify({
-                  width: widthChanged,
-                  height: heightChanged,
-                }),
-              )
+              this.debouncedNotify({
+                width: widthChanged,
+                height: heightChanged,
+              })
               this.lastWidth = entry.contentRect.width
               this.lastHeight = entry.contentRect.height
             }

diff --git a/packages/core/src/utils/resize/resize.subject.ts b/packages/core/src/utils/resize/resize.subject.ts
@@ -1,3 +1,4 @@
+import { rIC } from '../helpers'
 import { SingleSubject } from '../types/signal'
 import { BalResizeInfo, BalResizeListenerFn, BalResizeObserver } from './resize.interfaces'
 import { BalResizeListener } from './resize.listener'
@@ -7,7 +8,7 @@ export class BalResizeSubject extends SingleSubject<BalResizeObserver, BalResize
 
   constructor() {
     super((observer, data) => {
-      observer.resizeListener(data)
+      rIC(() => observer.resizeListener(data))
     })
   }