Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: add a11y for toast and improve spinner circle #1574

Merged
merged 14 commits into from
Jan 16, 2025
Merged

✨ feat: add a11y for toast and improve spinner circle #1574

merged 14 commits into from
Jan 16, 2025

Conversation

hirsch88
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7c3e5f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@baloise/ds-core Minor
@baloise/ds-angular-common Minor
@baloise/ds-angular-legacy Minor
@baloise/ds-angular-module Minor
@baloise/ds-angular Minor
@baloise/ds-react Minor
@baloise/ds-table Minor
@baloise/ds-testing Minor
@baloise/ds-vue Minor
docs Patch
e2e Patch
@baloise/ds-brand-icons Minor
@baloise/ds-css Minor
@baloise/ds-devkit Minor
@baloise/ds-favicons Minor
@baloise/ds-fonts Minor
@baloise/ds-icons Minor
@baloise/ds-maps Minor
@baloise/ds-styles Minor
@baloise/ds-tokens Minor
@baloise/ds-nx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 1:41pm
design-system-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 1:41pm

@hirsch88 hirsch88 changed the title chore: add a11y for toast and improve spinner circle ✨ feat: add a11y for toast and improve spinner circle Jan 15, 2025
@hirsch88
Copy link
Member Author

hirsch88 commented Jan 15, 2025 •
edited by github-actions bot
Loading

🚨 Create Base Image Failed!

Specs: bal-toast.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member Author

hirsch88 commented Jan 16, 2025 •
edited by github-actions bot
Loading

🚨 Create Base Image Failed!

Specs: bal-snackbar.visual.cy.ts,bal-toast.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member Author

hirsch88 commented Jan 16, 2025 •
edited by github-actions bot
Loading

📸 Create Base Image finished!

Specs: bal-toast.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member Author

hirsch88 commented Jan 16, 2025 •
edited by github-actions bot
Loading

📸 Create Base Image finished!

Specs: bal-toast.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member Author

hirsch88 commented Jan 16, 2025 •
edited by github-actions bot
Loading

🚨 Create Base Image Failed!

Specs: bal-snackbar.visual.cy

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member Author

hirsch88 commented Jan 16, 2025 •
edited by github-actions bot
Loading

📸 Create Base Image finished!

Specs: bal-snackbar.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member Author

hirsch88 commented Jan 16, 2025 •
edited by github-actions bot
Loading

📸 Create Base Image finished!

Specs: bal-notification.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member Author

hirsch88 commented Jan 16, 2025 •
edited by github-actions bot
Loading

📸 Create Base Image finished!

Specs: bal-toast.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88 hirsch88 merged commit 1c3fdd4 into main Jan 16, 2025
18 checks passed
@hirsch88 hirsch88 deleted the feat/toast-a11y branch January 16, 2025 14:07
@hirsch88 hirsch88 mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc0z m4rc0z Awaiting requested review from m4rc0z m4rc0z is a code owner

@yannickholzenkamp yannickholzenkamp Awaiting requested review from yannickholzenkamp yannickholzenkamp is a code owner

@mmarinkov mmarinkov Awaiting requested review from mmarinkov mmarinkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hirsch88