Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic versioning #744

Merged
merged 24 commits into from
Oct 26, 2023
Merged

Conversation

tomicapretto
Copy link
Collaborator

With this PR I add setuptools_scm. It helps to handle automatic versioning. It takes the version from git tags, and then it adds some stuff to make it unique. This way, we get unique version numbers for different commits and people can install from git with more ease.

jt-lab and others added 23 commits September 21, 2023 13:51
Perhaps the rationale behind centering could be added to help user decide whether to turn it on or not. But I'm not entirely sure about this.
… character, or so.

Also deleted superflous space unrelated to the black's complaint
... for more informative output.
Cannot make changes locally at the moment. Hence so many commits ...
It's a bit annoying, I can only work from the web interface currently, but hopefully all typos are resolved now
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #744 (981706e) into main (93b2c11) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   89.80%   89.79%   -0.02%     
==========================================
  Files          44       43       -1     
  Lines        3609     3605       -4     
==========================================
- Hits         3241     3237       -4     
  Misses        368      368              
Files Coverage Δ
bambi/__init__.py 77.77% <100.00%> (+1.30%) ⬆️
bambi/backend/pymc.py 94.97% <100.00%> (+0.02%) ⬆️
bambi/models.py 79.28% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto
Copy link
Collaborator Author

I don't know why commits from @jt-lab keep appearing in all my PRs. Do any of you know what I'm missing? @GStechschulte @aloctavodia @canyon289

@canyon289
Copy link
Collaborator

It looks like the merge you attempted caused the issues. do you want help cleaning up the commit tree?

@tomicapretto
Copy link
Collaborator Author

It looks like the merge you attempted caused the issues. do you want help cleaning up the commit tree?

Is it fixed if I just delete the repo and create it again? I know there are more professional ways but my guess is it's going to be painful haha

@canyon289
Copy link
Collaborator

I wouldnt delete the repo.......

You could create a new branch on top of main and copy over your changes and then force push to this PR, thats what I'd reccomend

@canyon289
Copy link
Collaborator

Oh you meant local repo which yea thatd be fine but creating a new branch on main is equivalent. i thought you meant github repo (which definitely dont do)

@tomicapretto tomicapretto merged commit 281fa1e into bambinos:main Oct 26, 2023
4 checks passed
@tomicapretto tomicapretto deleted the automatic-version branch October 26, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants