Fix random seed handling for "vi" #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random seed was not properly passed when `inference_method="vi"`. This is now resolved.
|
Many thanks for catching this @B-Deforce ! 👍🏼 I think the failing test is unrelated to your code changes. Did the tests pass locally for you? |
|
Hey @GStechschulte, one test indeed failed due to an issue unrelated to my changes. However, I looked into it and it appeared to be some boundary value issue for the beta regression test. I fixed this now in commit b9058b5 (latest commit in this PR) making all tests pass locally. |
|
Ah great @B-Deforce. Thanks for proactively fixing this and for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random seed was not properly passed on when
inference_method="vi". This is now resolved.requirements.txt,requirements-dev.txt, etc.)black.pylint.