-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more questions nin FAQ #881
base: main
Are you sure you want to change the base?
Conversation
Adding piecewise regression examples in example docs
Added more questions for FAQ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the initial commits—I left some comments. Overall, I don't think the proposed questions align well with the types of questions Bambi users are looking for answers for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be added in the README as there is already a minimal example there. I would make another PR specifically demonstrating how to use Bambi for piecewise regression in a Jupyter notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok;)
Should I close this PR then?
prior that doesn't cover the domain of the data such as using a HalfNormal prior for a | ||
parameter that can be negative). | ||
|
||
|
||
## Model Specification Questions | ||
|
||
### My data has a non-normal distributions, can I still use Bambi? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan on answering this question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one?
Are you asking for this one - "My data has a non-normal distributions, can I still used Bambi?"
Bayesian modelling allows graceful handling of small sample sizes by judicious use of | ||
prior distributions. | ||
|
||
### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan on adding another section here?
@@ -33,6 +43,18 @@ Yes, Bambi supports inference on GPUs and TPUs using the numpyro and blackjax ba | |||
See the API for "fit" method for more details | |||
[here](https://bambinos.github.io/bambi/api/Model.html#bambi.Model.fit). | |||
|
|||
### My sampler through errors/indicating divergences, what should I do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this deserves an FAQ. This is a more general question regarding sampling. Not necessarily specific to Bambi.
@@ -14,7 +14,17 @@ inference. | |||
* PyMC is a library for Bayesian modelling, and is the backend used by Bambi. | |||
It is a very powerful library, but can be challenging to use for beginners. | |||
Bambi provides a simple interface for specifying models, and allows for easy inference via | |||
MCMC or variational inference using PyMC. | |||
|
|||
### Why have a Bayesian regression library? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about including this section in the FAQ. Yes, it is related to Bambi, but it is more asking a question of what the right level of abstraction is.
Addresses #644
Questions for FAQ.
Thank your for opening a PR!
Before you proceed, please check the following notes.
requirements.txt
,requirements-dev.txt
, etc.)black
.pylint
.