fix(reconnect): Manage max retries when connection error

channel-sender/config/config-local.yaml

@@ -12,7 +12,7 @@ channel_sender_ex:
   # initial time in seconds to wait before re-send a message not acked to a channel
   initial_redelivery_time: 900
 
-  # max time in seconds to wait the client to send the auth token
+  # max time in milliseconds to wait the client to send the auth token
   # before closing the channel
   socket_idle_timeout: 90000
 

clients/client-js/src/async-client.ts

@@ -77,7 +77,6 @@ export class AsyncClient {
     private onSocketOpen(event) {
         this.selectSerializerForProtocol();
         this.isOpen = true;
-        this.reconnectTimer.reset();
         this.resetHeartbeat();
         this.socket.send(`Auth::${this.actualToken}`)
         this.stateCallbacks.open.forEach((callback) => callback(event));
@@ -91,14 +90,15 @@ export class AsyncClient {
         }
     }
 
-    private onSocketError(event) {
+    private onSocketError(_event) {
         // console.log('error', event)
     }
 
     private onSocketMessage(event) {
         const message = this.serializer.decode(event)
         if (!this.isActive && message.event == "AuthOk") {
             this.isActive = true;
+            this.reconnectTimer.reset();
             console.log('async-client. Auth OK');
         } else if (message.event == ":hb" && message.correlation_id == this.pendingHeartbeatRef) {
             this.pendingHeartbeatRef = null;
@@ -182,6 +182,7 @@ export class AsyncClient {
     }
 
     private onSocketClose(event) {
+        this.isActive = false;
         console.warn(`async-client. channel close: ${event.code} ${event.reason}`);
         clearInterval(this.heartbeatTimer)
         const reason = this.extractReason(event.reason);

clients/client-js/src/retry-timer.ts

@@ -20,15 +20,17 @@ export class RetryTimer {
 
     public schedule(): void {
         if (typeof window !== 'undefined') {
-            const delayMS = this.delay();
-            console.log(`async-client. scheduling retry in ${delayMS} ms`);
-            this.timer = window.setTimeout(() => {
+            if (this.tries <= this.maxRetries) {
+                const delayMS = this.delay();
                 this.tries = this.tries + 1;
-                if (this.tries <= this.maxRetries) {
+                console.log(`async-client. scheduling retry in ${delayMS} ms`);
+                this.timer = window.setTimeout(() => {
                     console.log(`async-client. retrying ${this.tries} of ${this.maxRetries}`);
                     this.callback();
-                }
-            }, delayMS)
+                }, delayMS)
+            } else {
+                console.log(`async-client. max retries reached.`);
+            }
         } else {
             console.warn(`async-client. could not setup scheduler for rety: window is undefined.`);
         }

clients/client-js/test/retry-timer.test.ts

@@ -12,15 +12,16 @@ describe('Exponential Retry Timer Tests', function()  {
         let counter = 0;
         let lastTime = Date.now();
         let times: number[] = [];
+        const maxRetries = 7;
 
         let retryProcess = new Promise(resolve => {
             timer = new RetryTimer(() => {
                 let now = Date.now();
                 times.push(now - lastTime);
                 lastTime = now;
                 counter = counter + 1;
-                counter < 7 ? timer.schedule() : resolve(0);
-            }, 10, x => x );
+                counter < maxRetries ? timer.schedule() : resolve(0);
+            }, 10, x => x, maxRetries);
         });
 
         timer.schedule();