Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added rabbitmq/secrets manager driven adapters #68

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat: added rabbitmq/secrets manager driven adapters #68

merged 1 commit into from
Dec 6, 2023

Conversation

gabheadz
Copy link
Contributor

@gabheadz gabheadz commented Dec 6, 2023

Description

Added modules to integrate with rabbitmq and Aws secrets manager

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • the version of the mix.exs was increased
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog

@gabheadz gabheadz requested a review from santicalleg December 6, 2023 19:37
carlosbioingeniero
carlosbioingeniero reviewed Dec 6, 2023
View reviewed changes
Copy link

@carlosbioingeniero carlosbioingeniero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

carlosbioingeniero
carlosbioingeniero approved these changes Dec 6, 2023
View reviewed changes
Copy link

@carlosbioingeniero carlosbioingeniero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@gabheadz gabheadz merged commit 265e2b0 into master Dec 6, 2023
3 checks passed
@gabheadz gabheadz deleted the feature/rabbit-da branch December 6, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santicalleg santicalleg santicalleg approved these changes

@carlosbioingeniero carlosbioingeniero carlosbioingeniero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabheadz @santicalleg @carlosbioingeniero