Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simulator Layout #1624

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Update Simulator Layout #1624

merged 7 commits into from
Jan 9, 2025

Conversation

GrandSchtroumpf
Copy link
Collaborator

fix #1490

  • Limit width on simulator form & result to 1920px
  • Height of chart is the same as in trade & edit

Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0243042
Status: ✅  Deploy successful!
Preview URL: https://f2f26581.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1490.carbon-app-csq.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0243042
Status: ✅  Deploy successful!
Preview URL: https://acc69450.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1490.carbon-app-sei.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf marked this pull request as draft January 7, 2025 10:22
Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying carbon-app-celo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0243042
Status: ✅  Deploy successful!
Preview URL: https://22487430.carbon-app-celo.pages.dev
Branch Preview URL: https://issue--1490.carbon-app-celo.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying carbon-app-blast with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0243042
Status: ✅  Deploy successful!
Preview URL: https://cb40ae2b.carbon-app-blast.pages.dev
Branch Preview URL: https://issue--1490.carbon-app-blast.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf marked this pull request as ready for review January 8, 2025 11:16
Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left comments about the screenshots as they look different for the form which shouldn't happen

@GrandSchtroumpf GrandSchtroumpf merged commit 83e8706 into main Jan 9, 2025
4 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#1490 branch January 9, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply max width as we have on trade page
3 participants