Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): resolve issue preventing dashboard app from loading #514

Closed
wants to merge 25 commits into from

Conversation

baumstern
Copy link
Contributor

@baumstern baumstern commented May 24, 2024

Description

In the production build, there's an issue preventing the Dashboard app from loading in the browser. The following errors are logged:

Uncaught TypeError: Cannot read properties of undefined (reading 'decode')
    at Object.decode (index-CtFWE_9U.js:1659:103201)
    at _ (index-CtFWE_9U.js:1663:5200)
    at pg.decode (index-CtFWE_9U.js:1663:5379)
    at new kQe (index-CtFWE_9U.js:2270:189)
    at UI.generateApi (index-CtFWE_9U.js:2410:41)
    at index-CtFWE_9U.js:2410:288

The issue has been traced to UI.generateApi(), which is part of the siwe package. The siwe package was updated from version ^1.1.6 to ^2.1.4 in commit 871f01a. Bumping siwe to version ^2.3.2 resolves the current issue.

Related Issue

Does this introduce a breaking change?

  • Yes
  • No

Other information

neel-ds and others added 23 commits May 9, 2024 15:16
fix: resolve rebase conflicts

fix: resolve rebase conflicts

fix: resolve rebase conflicts

fix: resolve rebase conficts

fix: resolve rebase conflicts
fix: resolve rebase conflicts

fix: resolve rebase conflicts
Upgrade `ethers` and related dependencies to latest version
Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:23pm

@vplasencia
Copy link
Member

Hey @baumstern thank you very much for creating this PR. Is Bandada working fine for you in dev environment? I just tested it and I see some errors in the browser console.

I think this could help:

spruceid/siwe#165

spruceid/siwe#154

@baumstern
Copy link
Contributor Author

Hey @baumstern thank you very much for creating this PR. Is Bandada working fine for you in dev environment? I just tested it and I see some errors in the browser console.

I think this could help:

spruceid/siwe#165

spruceid/siwe#154

I bumped siwe to ^2.3.2 to include the fix mentioned in this comment: spruceid/siwe#165 (comment).

Just in case, you might need to provide the VITE_PROJECT_ID environment variable to prevent an issue related to wallet connect like following console errors:
Screenshot 2024-05-24 at 23 16 56

Copy link
Collaborator

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely - tysm!

@baumstern
Copy link
Contributor Author

update: bumped the version of siwe from bandada-api package as well.

Also, currently we are troubleshooting the issue that this PR introduced with @vplasencia. Signed-in status doesn't persist from her side. But I failed to reproduce it.

@0xjei
Copy link
Collaborator

0xjei commented Jun 5, 2024

update: bumped the version of siwe from bandada-api package as well.

Also, currently we are troubleshooting the issue that this PR introduced with @vplasencia. Signed-in status doesn't persist from her side. But I failed to reproduce it.

thx for the updates - keep us posted.

@vplasencia
Copy link
Member

Hey @baumstern!

I will close this PR because there is a new branch that will serve as a reference for future updates of the ethers dependency. Please see https://github.com/bandada-infra/bandada/tree/chore/update-ethers

There is also a new issue focused on improving the wallet UX, please see: #550

Thank you very much for the work 🙏

@vplasencia vplasencia closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants