Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminID #598

Merged
merged 7 commits into from
Nov 1, 2024
Merged

AdminID #598

merged 7 commits into from
Nov 1, 2024

Conversation

pheobeayo
Copy link

Description

Added the admin section for copying

Related Issue

https://github.com//issues/588

Does this introduce a breaking change?

  • Yes
  • [ No] No

Other information

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 8:42pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 8:42pm

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pheobeayo looks great! Thank you very much for creating this PR. I just left one comment.

apps/dashboard/src/pages/group.tsx Outdated Show resolved Hide resolved
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also run yarn prettier:write and push the changes?

apps/dashboard/src/pages/group.tsx Outdated Show resolved Hide resolved
apps/dashboard/src/pages/group.tsx Outdated Show resolved Hide resolved
@pheobeayo
Copy link
Author

pheobeayo commented Nov 1, 2024

changes made

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pheobeayo great work! Thank you very much!

@vplasencia vplasencia changed the base branch from main to dev November 1, 2024 20:15
@vplasencia
Copy link
Member

Hey @pheobeayo the PR is correct, but there is an issue in the CI with the style, could you run yarn prettier:write and push the changes to fix it?

@pheobeayo
Copy link
Author

okay

Copy link

gitpoap-bot bot commented Nov 1, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Bandada Contributor:

GitPOAP: 2024 Bandada Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants