fix(template/EKS/NP): fixed parameter metadata #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
added
cloud/aws
distribution/eks
| @@ -12,7 +12,7 @@ Metadata: | |||
| - ClusterName | |||
| - ClusterControlPlaneSecurityGroup | |||
| - NodeSecurityGroup | |||
| - CustomSecurityGroup | |||
| - SecurityGroups | |||
There was a problem hiding this comment.
Isn't it called CustomSecurityGroups?
There was a problem hiding this comment.
In the latest update (#3315) it was renamed to SecurityGroups, that's where the discrepancy was introduced which I'm trying to fix here.
There was a problem hiding this comment.
My2cents are to merge this and if we want to change the name again, let's do that in a different PR.
sancyx
approved these changes
Nov 17, 2020
pregnor
force-pushed
the
fix/eks-np-template
branch
from
62127d6 to
c98f5cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixed the EKS node pool CloudFormation template's metadata parameter listing regarding the newly introduced security groups.
Why?
Because the parameter was renamed, but the template was not consolidated.
Additional context
This doesn't affect the behavior of the template, it only affects the listing of the resulting parameters on the stack.
#3300 depends on this
Checklist
Implementation tested (with at least one cloud provider)Code meets the Developer GuideOpenAPI and Postman files updated (if needed)User guide and development docs updated (if needed)Related Helm chart(s) updated (if needed)