Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use int/bool instead of longer variant #1524

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Use int/bool instead of longer variant #1524

merged 3 commits into from
Feb 19, 2024

Conversation

barryvdh
Copy link
Owner

@barryvdh barryvdh commented Feb 19, 2024 •
edited
Loading

Summary

Use the short variants, int and bool. This is more like the official types and defaults in Laravel.

Type of change

  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

mfn
mfn approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Again, something we might keep for the 3.x release though…

@barryvdh
Copy link
Owner Author

Master is currently 3.x yes

@barryvdh barryvdh merged commit d7ed749 into master Feb 19, 2024
28 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat-shorter-types branch February 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barryvdh @mfn