Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer fix-style #1558

Merged
merged 1 commit into from
Jul 12, 2024
Merged

composer fix-style #1558

merged 1 commit into from
Jul 12, 2024

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Jun 12, 2024

Summary

As pointed out in #1557 (comment) , there are pending changes from php-cs-fixer not being applied.

Let's apply them!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Jun 12, 2024
@mfn
Copy link
Collaborator Author

mfn commented Jun 12, 2024

There's a workflow https://github.com/barryvdh/laravel-ide-helper/blob/master/.github/workflows/fix-code-style.yml but there are multiple reasons it actually does not work:

  • it does not run on forks, so no user benefits from this usually
  • in it current configuration it does run after a merge to master
  • which it did last time, but because master is a protected branch, it can't push with the pure github token -> it would require a PAT
    • but actually I wouldn't advise it to push to master anyway

For that to be useful it should be able to push on PRs, but 🤷🏼 how to achieve that.

@mfn mfn requested a review from barryvdh June 12, 2024 05:21
@barryvdh barryvdh merged commit 0cf178a into master Jul 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants