Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 310 include lang namespaces #342

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gjm
Copy link

@gjm gjm commented Oct 24, 2019

This PR addresses issue #310

It creates a new database table (ltm_namespaces) to store declared translation namespaces' language paths.

It refactors the import and export processes to handle registered namespaces in service providers. It creates groups with the form namespace::group for each of them. It also breaks down each vendor translations into a separate group (vendor/vendorname/group) instead of joining all translations into a single one.

The Manager::importTranslations() method, AFAIK, is only publicly called with the $replace argument and both other arguments are for internal use, so I refactored it to have only this argument and broke it down into two other methods, one for array translations and another for JSON.

@fsou
Copy link

fsou commented Oct 28, 2019

Nice job.
This worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants