Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audit] #4: Use FixedPointMathLib.mulWad in EDA.currentPrice #59

Merged
merged 3 commits into from
Jul 9, 2024
Merged

[audit] #4: Use FixedPointMathLib.mulWad in EDA.currentPrice #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b85b42f
Replaced computation using mulWad
Keshavrajsinghal Jun 25, 2024
fae5850
typo fix
Keshavrajsinghal Jun 26, 2024
0439fdc
Typo fixed
Keshavrajsinghal Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/EDAPrice.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ library EDAPrice {
uint256 percentWadRemainingPerPeriod = FixedPointMathLib.WAD - perPeriodDecayPercentWad;

// percentWadRemainingPerPeriod can be safely cast because < 1e18
// ratio can be safely cast because will not overflow unless ratio > int256.max,
// which would require secondsElapsed > int256.max, i.e. > 5.78e76 or 1.8e69 years
// ratio can be safely cast because will not overflow unless ratio > type(int256).max,
// which would require secondsElapsed > type(int256).max, i.e. > 5.78e76 or 1.8e69 years

int256 multiplier = FixedPointMathLib.powWad(int256(percentWadRemainingPerPeriod), int256(ratio));
uint256 price = (startPrice * uint256(multiplier)) / FixedPointMathLib.WAD;
uint256 price = FixedPointMathLib.mulWad(startPrice, uint256(multiplier));
return price;
}
}