Add ERC721 discount validator #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// This discount validator should only be used for "soul-bound" tokens. | ||
| /// | ||
| /// @author Coinbase (https://github.com/base-org/usernames) | ||
| contract ERC721DiscountValidator is IDiscountValidator { |
There was a problem hiding this comment.
how will we distribute?
There was a problem hiding this comment.
For launch we're integrating the buildathon NFT which they're distributing
| /// | ||
| /// @return `true` if the validation data provided is determined to be valid for the specified claimer, else `false`. | ||
| function isValidDiscountRegistration(address claimer, bytes calldata) external view returns (bool) { | ||
| return (token.balanceOf(claimer) > 0); |
There was a problem hiding this comment.
how do we track if they already claimed?
There was a problem hiding this comment.
RegistrarController tracks discount claimants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generic discount validator allows us to offer discounts to an arbitrary soul-bound ERC721 token. We don't explicitly check tokenIds; just the presence of a nonzero balance for the stored token address.