Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mainnet] Set new L1 resolver as resolver for base.eth #201

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

stevieraykatz
Copy link
Contributor

@stevieraykatz stevieraykatz commented Jul 30, 2024

EXECUTED: https://etherscan.io/tx/0x15a5263c5531d27f6f91cfe79167ddaf0db38a29ce50106ff0e3380b468722df

The L1 Resolver contract set via 2024-07-23-set-l1-resolver runbook had a bug wherein generic resolve requests for the base.eth name itself were failing. This was due to the fact that the rootResolver does not implement the resolve method.

The issue with the contract was fixed in this PR and deployed in this SCM deploy. This runbook will set the resolver for the base.eth name to the newly deployed, fixed version of the L1 Resolver contract.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 30, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stevieraykatz stevieraykatz marked this pull request as ready for review July 30, 2024 17:03
@stevieraykatz stevieraykatz merged commit 482bfd9 into main Jul 30, 2024
3 checks passed
@stevieraykatz stevieraykatz deleted the redeploy-l1-resolver branch July 30, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants